Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test workflow runs against merge commit, not HEAD of feature branch #36

Open
patcon opened this issue Feb 20, 2022 · 2 comments
Open
Labels
bug Something isn't working infrastructure

Comments

@patcon
Copy link
Member

patcon commented Feb 20, 2022

Re-ticketed from: #33 (comment)

It seems that the test workflow is being run against the feature branch rather than against the merge commit of feature+mainline.

@patcon patcon added bug Something isn't working infrastructure labels Feb 20, 2022
@patcon
Copy link
Member Author

patcon commented Feb 20, 2022

Seems a little trickier than I expected, but I think it's fixable.

Will be helpful:

@patcon
Copy link
Member Author

patcon commented Feb 20, 2022

Another related issue, which I resolved by rebasing #33 against main after the merge of the other PR (that added the new files):
https://github.com/g0v-network/domains/runs/5267184572?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant