Question about qt_sink class constructor

[ashley-b]

When I was directly constructing a qt_sink in a multi sink arrangement with a file logger. I found It was displaying nothing till I released I was missing meta_method since it defaults to an empty string. I think the arguments qt_object and meta_method should not have default as it does make sense, since there are no setters to change theses values after construction.

spdlog/include/spdlog/sinks/qt_sinks.h

Line 26 in 243c4be

qt_sink(QObject *qt_object = nullptr, const std::string &meta_method = "") {

[gabime]

agreed. .pr would be most welcome.