There's no need to define the `Mutex mutex_` as mutable since class base_sink has no `const` method. #2139

sunlong169 · 2021-10-16T15:05:16Z

The related code snippet is seen at https://github.com/gabime/spdlog/blob/v1.x/include/spdlog/sinks/base_sink.h line 40.
There's no need to define the Mutex mutex_ as mutable since class base_sink has no const method.

The text was updated successfully, but these errors were encountered:

gabime · 2021-10-16T15:36:25Z

Right. PR is welcome.

sunlong169 changed the title ~~There's no need to define the type of Mutex mutex_ as mutable since class base_sink has no const method.~~ There's no need to define the Mutex mutex_ as mutable since class base_sink has no const method. Oct 16, 2021

sunlong169 mentioned this issue Oct 16, 2021

No need to define the Mutex mutex_ as mutable there is no const method. #2140

Merged

gabime closed this as completed Oct 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

There's no need to define the `Mutex mutex_` as mutable since class base_sink has no `const` method. #2139

There's no need to define the `Mutex mutex_` as mutable since class base_sink has no `const` method. #2139

sunlong169 commented Oct 16, 2021 •

edited

Loading

gabime commented Oct 16, 2021

There's no need to define the Mutex mutex_ as mutable since class base_sink has no const method. #2139

There's no need to define the Mutex mutex_ as mutable since class base_sink has no const method. #2139

Comments

sunlong169 commented Oct 16, 2021 • edited Loading

gabime commented Oct 16, 2021

There's no need to define the `Mutex mutex_` as mutable since class base_sink has no `const` method. #2139

There's no need to define the `Mutex mutex_` as mutable since class base_sink has no `const` method. #2139

sunlong169 commented Oct 16, 2021 •

edited

Loading