Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win eventlog sink event ID type in constructor is incorrect. #2596

Closed
Tagl opened this issue Jan 6, 2023 · 1 comment
Closed

Win eventlog sink event ID type in constructor is incorrect. #2596

Tagl opened this issue Jan 6, 2023 · 1 comment

Comments

@Tagl
Copy link
Contributor

Tagl commented Jan 6, 2023

In the constructor of win_eventlog_sink the type for event_id is WORD but should be DWORD according to the eventlog API.

spdlog/include/spdlog/sinks/win_eventlog_sink.h

Line 261 in 287a00d

win_eventlog_sink(std::string const &source, WORD event_id = 1000 /* according to mscoree.dll */)

@tt4g
Copy link
Contributor

tt4g commented Jan 6, 2023

PR is welcome.

@Tagl Tagl mentioned this issue Jan 8, 2023
Merged
@gabime gabime closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabime @Tagl @tt4g