Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML encoding is fixed to UTF-8 #147

Closed
gabriel-vasile opened this issue Mar 31, 2021 · 2 comments
Closed

XML encoding is fixed to UTF-8 #147

gabriel-vasile opened this issue Mar 31, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@gabriel-vasile
Copy link
Owner

Use the encoding attribute to detect correct encoding.
Similar discussion as #145.
@gabriel-vasile gabriel-vasile added the good first issue Good for newcomers label Jun 4, 2021
@AidanKenney
Copy link

Hey @gabriel-vasile, I'd like to take a shot at this one.

@gabriel-vasile
Copy link
Owner Author

Hi, I'm sorry but this issue was solved in 6e783c3 and I forgot to close it.
There are still #155, #170, #171, #172 that you can look at if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabriel-vasile @AidanKenney