Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong return type in docker.compose.run? #285

Closed
mdantonio opened this issue Nov 24, 2021 · 1 comment · Fixed by #289
Closed

Wrong return type in docker.compose.run? #285

mdantonio opened this issue Nov 24, 2021 · 1 comment · Fixed by #289
Labels
bug Something isn't working

Comments

@mdantonio
Copy link
Contributor

mdantonio commented Nov 24, 2021 •
edited
Loading

The return type of compose.run is Union[str, python_on_whales.components.container.cli_wrapper.Container]
ma in case of stream it is returned stream_stdout_and_stderr... so the return type should be

Union[str, python_on_whales.components.container.cli_wrapper.Container, Iterable[Tuple[str, bytes]]], is it correct?
@gabrieldemarmiesse
Copy link
Owner

Yup! Seems you're right!

@gabrieldemarmiesse gabrieldemarmiesse added the bug Something isn't working label Nov 29, 2021
@gabrieldemarmiesse gabrieldemarmiesse mentioned this issue Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix return type of compose.run() gabrieldemarmiesse/python-on-whales
2 participants
@mdantonio @gabrieldemarmiesse