Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing condition in Container.logs() - may raise DockerException rather than NoSuchContainer if container exits #647

Open
LewisGaul opened this issue Oct 24, 2024 · 1 comment

Comments

@LewisGaul
Copy link
Collaborator

This is because the utils.stream_stdout_and_stderr() function doesn't handle the different error outputs like utils.run() does. Could we factor this logic out and use it from the stream_stdout_and_stderr() function too?

@gabrieldemarmiesse
Copy link
Owner

That seems like a good improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants