Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add License #18

Open
gabzim opened this issue Feb 18, 2020 · 5 comments
Open

Add License #18

gabzim opened this issue Feb 18, 2020 · 5 comments
Assignees

Comments

@gabzim
Copy link
Owner

gabzim commented Feb 18, 2020

We should pick a license and add it to the project files

@gabzim gabzim self-assigned this Feb 18, 2020
@johachi
Copy link
Collaborator

johachi commented Feb 20, 2020

Haven't you already picked ISC? Or did you mean to all files in the project?

@gabzim
Copy link
Owner Author

gabzim commented Feb 20, 2020

Yes I meant in the project files, is that necessary? I see a lot of open source projects doing it and figured you might need to add it to every file.

@johachi
Copy link
Collaborator

johachi commented Feb 21, 2020

I googled a bit. It seems like we should have a LICENSE.txt or a LICENSE.md in the root of the project, and then also a disclaimer in every source file.

I think the disclaimer (for each source file) could easily be written when linting the file.

@johachi johachi mentioned this issue Feb 22, 2020
@johachi
Copy link
Collaborator

johachi commented Feb 22, 2020

@gabzim I added a license file and a section to the readme in this PR: #20

Could you please see if you can add license info automatically in the source file on linting?

TODO:

  • Add license.txt
  • Add license info to readme.md
  • Add license disclaimer to source files

@johachi
Copy link
Collaborator

johachi commented Feb 22, 2020

I see now that you assigned yourself to this issue. Hope you don't mind that I made a small PR addressing some points on this PR. Feel free to reject it if it's not what you imagined :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants