Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-frame: Subscribe was called outside of a reactive context #13

Closed
WeissP opened this issue Mar 19, 2023 · 2 comments
Closed

re-frame: Subscribe was called outside of a reactive context #13

WeissP opened this issue Mar 19, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@WeissP
Copy link

WeissP commented Mar 19, 2023

Hi, I am not sure if it is a bug. But whenever I press keys in an input element, a warning re-frame: Subscribe was called outside of a reactive context occurs.

To reproduce:

  1. run command lein new re-frame <app-name> +re-pressed
  2. change main-panel in views.cljs to
(defn main-panel [] [:input])
  1. press a key in the input element
@gadfly361 gadfly361 added the help wanted Extra attention is needed label Mar 19, 2023
@gadfly361
Copy link
Owner

@WeissP thanks for reporting this issue.

I am open to reviewing PRs if you or anyone reading this thread is interested in helping fix this.

@gadfly361
Copy link
Owner

There is a fork of re-pressed that fixes this issue. Note: there are trade-offs between this repo and the fork. This repo has the console warnings described in this issue but guarantees event ordering, while the fork fixes the console warnings, but doesn't guarantee event ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants