-
Notifications
You must be signed in to change notification settings - Fork 4
/
Copy pathcran-comments
353 lines (214 loc) · 9.92 KB
/
cran-comments
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
# https://cran.r-project.org/submit.html
==== 7.3-1
* Fixes to support DuckDB 0.4.0 (Avoid CAST(AS NUMERIC) and associated accuracy loss)
Tested on R-release Win/MacOS/Ubuntu and R-devel Ubuntu.
The source to build the package can be found here, along with the README:
https://github.com/gadget-framework/mfdb/tree/v7.3-1
Full history can be found in the ChangeLog:
https://github.com/gadget-framework/mfdb/blob/v7.3-1/ChangeLog
Differences since the previous submission:
https://github.com/gadget-framework/mfdb/compare/v7.3-0...v7.3-1
Built documentation can be found here:
http://gadget-framework.github.io/mfdb/
CI test reports can be found here:
https://github.com/gadget-framework/mfdb/actions/runs/2535758934
== \dontrun{} usages:
* \dontrun{# NB: Requires a PostgreSQL installation, see README
The MFDB package manages a PostgreSQL schema, whilst most examples use a
temporary-file DuckDB database, this isn't possible for all examples. These
examples should be disabled on CRAN testing hosts.
* \dontrun{# NB: Requires a PostgreSQL installation, and creation of extra users
In addition, these examples require an additional user, to demonstrate
permission-setting. These examples should be disabled on CRAN testing hosts.
On 2020-04-09 18:01, Uwe Ligges wrote:
> CRAN does not have PostgreSQL installed everywhere. Winbuilder has.
>
> So we can go for \dontrun here.
>
> Best,
> Uwe Ligges
==== 7.3-0
* Fixes to support DuckDB 0.3.4 (MFDB unit tests not correctly ignoring ordering)
* Remove class() == "string" instances, as per latest R-devel
Tested on R-release Win/MacOS/Ubuntu and R-devel Ubuntu.
The source to build the package can be found here, along with the README:
https://github.com/mareframe/mfdb/tree/v7.3-0
Full history can be found in the ChangeLog:
https://github.com/gadget-framework/mfdb/blob/v7.3-0/ChangeLog
Differences since the previous submission:
https://github.com/mareframe/mfdb/compare/v7.2-0...v7.3-0
Built documentation can be found here:
http://gadget-framework.github.io/mfdb/
CI test reports can be found here:
https://github.com/gadget-framework/mfdb/actions/runs/2453944562
== \dontrun{} usages:
* \dontrun{# NB: Requires a PostgreSQL installation, see README
The MFDB package manages a PostgreSQL schema, whilst most examples use a
temporary-file DuckDB database, this isn't possible for all examples. These
examples should be disabled on CRAN testing hosts.
* \dontrun{# NB: Requires a PostgreSQL installation, and creation of extra users
In addition, these examples require an additional user, to demonstrate
permission-setting. These examples should be disabled on CRAN testing hosts.
On 2020-04-09 18:01, Uwe Ligges wrote:
> CRAN does not have PostgreSQL installed everywhere. Winbuilder has.
>
> So we can go for \dontrun here.
>
> Best,
> Uwe Ligges
==== 7.2.0
* Fixes to support DuckDB 0.3.1 (Bugs in dbWriteTable type casting)
* Add mfdb_dplyr_table(), for querying any table
* Fix selecting from taxonomy tables via. dplyr
Tested on R-release Win/MacOS/Ubuntu and R-devel Ubuntu.
The source to build the package can be found here, along with the README:
https://github.com/mareframe/mfdb/tree/v7.2-0
Full history can be found in the ChangeLog:
https://github.com/gadget-framework/mfdb/blob/v7.1-1/ChangeLog
Differences since the previous submission:
https://github.com/mareframe/mfdb/compare/v7.1-1...v7.2-0
Built documentation can be found here:
http://gadget-framework.github.io/mfdb/
CI test reports can be found here:
https://github.com/gadget-framework/mfdb/actions/runs/1486760389
== \dontrun{} usages:
* \dontrun{# NB: Requires a PostgreSQL installation, see README
The MFDB package manages a PostgreSQL schema, whilst most examples use a
temporary-file DuckDB database, this isn't possible for all examples. These
examples should be disabled on CRAN testing hosts.
* \dontrun{# NB: Requires a PostgreSQL installation, and creation of extra users
In addition, these examples require an additional user, to demonstrate
permission-setting. These examples should be disabled on CRAN testing hosts.
On 2020-04-09 18:01, Uwe Ligges wrote:
> CRAN does not have PostgreSQL installed everywhere. Winbuilder has.
>
> So we can go for \dontrun here.
>
> Best,
> Uwe Ligges
==== 7.1-1
Bugfix submission:
* Correct tests to work whilst using DuckDB 0.3.0
* Fix vignette generation on oldrel
Tested on R-release Win/MacOS/Ubuntu and R-devel Ubuntu.
The source to build the package can be found here, along with the README:
https://github.com/mareframe/mfdb/tree/v7.1-1
Full history can be found in the ChangeLog:
https://github.com/gadget-framework/mfdb/blob/v7.1-1/ChangeLog
Differences since the previous submission:
https://github.com/mareframe/mfdb/compare/v7.1-0...v7.1-1
Built documentation can be found here:
http://gadget-framework.github.io/mfdb/
CI test reports can be found here:
https://github.com/gadget-framework/mfdb/actions/runs/1323361470
== \dontrun{} usages:
* \dontrun{# NB: Requires a PostgreSQL installation, see README
The MFDB package manages a PostgreSQL schema, whilst most examples use a
temporary-file DuckDB database, this isn't possible for all examples. These
examples should be disabled on CRAN testing hosts.
* \dontrun{# NB: Requires a PostgreSQL installation, and creation of extra users
In addition, these examples require an additional user, to demonstrate
permission-setting. These examples should be disabled on CRAN testing hosts.
On 2020-04-09 18:01, Uwe Ligges wrote:
> CRAN does not have PostgreSQL installed everywhere. Winbuilder has.
>
> So we can go for \dontrun here.
>
> Best,
> Uwe Ligges
==== 7.1-0
Upgrade submission, major changes being:
* DuckDB & SQLite support
* More detailed trip / port / population / vessel_owner taxonomies
* Columns to store weight breakdowns
Tested on R-release Win/MacOS/Ubuntu and R-devel Ubuntu.
The source to build the package can be found here, along with the README:
https://github.com/mareframe/mfdb/tree/v7.1-0
Full history can be found in the ChangeLog:
https://github.com/gadget-framework/mfdb/blob/v7.1-0/ChangeLog
Differences since the previous submission:
https://github.com/mareframe/mfdb/compare/v6.2-0...v7.1-0
Built documentation can be found here:
http://gadget-framework.github.io/mfdb/
CI test reports can be found here:
https://github.com/gadget-framework/mfdb/actions/runs/1143922066
== Possibly mis-spelled words in DESCRIPTION:
* MareFrame (3:8)
The project that package was named after.
* PostgreSQL (10:36)
The database.
== \dontrun{} usages:
* \dontrun{# NB: Requires a PostgreSQL installation, see README
The MFDB package manages a PostgreSQL schema, whilst most examples use a
temporary-file DuckDB database, this isn't possible for all examples. These
examples should be disabled on CRAN testing hosts.
* \dontrun{# NB: Requires a PostgreSQL installation, and creation of extra users
In addition, these examples require an additional user, to demonstrate
permission-setting. These examples should be disabled on CRAN testing hosts.
On 2020-04-09 18:01, Uwe Ligges wrote:
> CRAN does not have PostgreSQL installed everywhere. Winbuilder has.
>
> So we can go for \dontrun here.
>
> Best,
> Uwe Ligges
==== 6.2-0
Resubmission to address the following comments:
On 2020-03-08 18:03, Martina Schmirl wrote:
> Please do not write to the user filespace. If you
> really have to write out something, use tempdir() if the user is not
> asked and in examples.
All examples now use tempfile()
> Please add small files needed for the examples or vignette in the
> inst/extdata subfolder of your package and use system.file() to get
> the correct package path.
> e.g. mfdb_import_data.Rd
As a special case, the 'examples' schema will pre-load some test data, which is
used by the examples.
> \dontrun{} should only be used if the example really cannot be
> executed (e.g. because of missing additional software, missing API
> keys, ...) by the user. That's why wrapping examples in \dontrun{}
> adds the comment ("# Not run:") as a warning for the user.
> Does not seem necessary.
> Please replace \dontrun with \donttest.
All reworked, \dontrun{} only used where truly necessary and postfixed with explanations. See below
> Please add \value to .Rd files regarding exported methods and explain
> the functions results in the documentation.
> If a function does not return a value, please document that too, e.g.
> \value{None}.
Also done.
Tested on R-devel winbuilder, debian stable and ubuntu R 3.6.
== Possibly mis-spelled words in DESCRIPTION:
* MareFrame (3:8)
The project that package was named after.
* PostgreSQL (10:36)
The database.
== \dontrun{} usages:
* \dontrun{# NB: Requires a PostgreSQL installation, see README
The MFDB package manages a PostgreSQL schema, so many of the examples aren't
useful without. These examples should be disabled on CRAN testing hosts.
* \dontrun{# NB: Requires a PostgreSQL installation, and creation of extra users
In addition, these examples require an additional user, to demonstrate
permission-setting. These examples should be disabled on CRAN testing hosts.
On 2020-04-09 18:01, Uwe Ligges wrote:
> CRAN does not have PostgreSQL installed everywhere. Winbuilder has.
>
> So we can go for \dontrun here.
>
> Best,
> Uwe Ligges
== Links
The source to build the package can be found here, along with the README:
https://github.com/mareframe/mfdb/tree/v6.2-0
Differences since the previous submission:
https://github.com/mareframe/mfdb/compare/v6.1-0...v6.2-0
Built documentation can be found here:
http://mareframe.github.io/mfdb/
CI test reports can be found here:
https://travis-ci.org/github/mareframe/mfdb/builds/673383365
==== 6.1-0
New submission, check --as-cran'ed under Debian Stable, Windows R-devel, and winbuilder.
The source to build the package can be found here, along with the README:
https://github.com/mareframe/mfdb/tree/v6.1-0
Built documentation can be found here:
http://mareframe.github.io/mfdb/