Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vnode.nodeName is deprecated in preactX,use vnode.type instead #1295

Closed
wen911119 opened this issue Jul 8, 2019 · 3 comments
Closed

vnode.nodeName is deprecated in preactX,use vnode.type instead #1295

wen911119 opened this issue Jul 8, 2019 · 3 comments

Comments

@wen911119
Copy link
Contributor

react-hot-loader/src/adapters/preact.js

Line 13 in 0c79474

vnode.nodeName = resolveType(vnode.nodeName);

@wen911119 wen911119 mentioned this issue Jul 8, 2019
Merged
@wen911119
Copy link
Contributor Author

20190708192417

@theKashey
Copy link
Collaborator

Without something like preactjs/preact#1120 Preact would not be hot-reloadable friendly anyway :(

@theKashey
Copy link
Collaborator

So - still the question - does this fix fixes anything with Preact? It should not work in any case.

theKashey referenced this issue Aug 10, 2019
@theKashey
Merge pull request #1296 from wen911119/master
e6e4dd7 
fix#1295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theKashey @wen911119