Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inheritance #9

Closed
gaearon opened this issue Aug 22, 2015 · 2 comments
Closed

Fix inheritance #9

gaearon opened this issue Aug 22, 2015 · 2 comments
Labels
bug

Comments

@gaearon
Copy link
Owner

gaearon commented Aug 22, 2015

Inheritance is bad, but at least we should tests we aren't breaking classes that inherit from something other than Component.
@gaearon
Copy link
Owner Author

gaearon commented Aug 25, 2015

It seems like we don't handle it nicely yet: gaearon/react-hot-loader#184

@gaearon gaearon added the bug label Aug 25, 2015
@gaearon gaearon changed the title Add tests for inheritance Fix inheritance Aug 25, 2015
@gaearon gaearon mentioned this issue Aug 25, 2015
Closed
@gaearon
Copy link
Owner Author

gaearon commented Aug 27, 2015

Fixed by #19.

@gaearon gaearon closed this as completed Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaearon