Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pipeline execution in docker container #92

Closed
michelvocks opened this issue Aug 25, 2018 · 5 comments
Closed

Support pipeline execution in docker container #92

michelvocks opened this issue Aug 25, 2018 · 5 comments
Labels
blocked Issue blocked by user which is working on this. enhancement

Comments

@michelvocks
Copy link
Member

Currently, pipelines are directly executed on the host system. It would be helpful if pipelines could be executed in their own docker container which can be removed after execution (like a sandbox).

@fubarhouse
Copy link

Will this feature be obligatory, opt-out or optional?

@michelvocks
Copy link
Member Author

Hello @fubarhouse 🤗
My idea is to make it optional. It will be disabled by default and can be activated manually.
Any opinions? 😄

@fubarhouse
Copy link

@michelvocks,

Thanks!

I guess, how it should be set up - it would be important to understand how it's being used currently by people. It could impact everybody using Gaia...

Obviously the best migration path would be to opt-into this functionality, but for best practice I would recommend opting out.

It's quite important to me that this is actually available rather than being forced. I personally don't mind either way but it's important that it's available in both forms. I love that you could support both - it would make Gaia once again a shining example in a crowd of highly opinionated systems.

@michelvocks michelvocks added the blocked Issue blocked by user which is working on this. label Feb 1, 2019
@michelvocks
Copy link
Member Author

This issue is now blocked until #46 is implemented because of the following reasons:

  • After working on several prototypes and POCs I have found out that implementing this issue without [Feature Request] Distributed execution #46 makes no sense.
  • The whole pipeline build process and pipeline execution is tightly coupled to local filesystem actions (which makes sense in my opinion).
  • Building and running pipelines inside a Docker container is a remote action.
  • As soon as [Feature Request] Distributed execution #46 has been implemented, we can simply start an agent in a Docker container, build the pipeline, execute the pipeline and finally kill the container.
  • This leaves the build process clean and one-purpose driven.

Sorry for delaying this feature once again but in the end, I think this is the best decision for Gaia and it's architecture.

@Skarlso
Copy link
Member

Skarlso commented Feb 14, 2020

Doonnee by #201 🎉

@Skarlso Skarlso closed this as completed Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue blocked by user which is working on this. enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants