Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seg fault issues in snapshotter.cpp #13

Open
jihyunl2 opened this issue Jul 26, 2022 · 1 comment
Open

Seg fault issues in snapshotter.cpp #13

jihyunl2 opened this issue Jul 26, 2022 · 1 comment

Comments

@jihyunl2
Copy link

jihyunl2 commented Jul 26, 2022 •
edited
Loading

I came across some lines in snapshotter.cpp such as 768 or 826 where smart pointers that haven't been allocated a portion of memory yet were causing segmentation fault.
@jihyunl2 jihyunl2 changed the title Segmentation Fault from snapshotter.cpp Segmentation fault from snapshotter.cpp Jul 26, 2022
@jihyunl2 jihyunl2 reopened this Jul 26, 2022
@jihyunl2 jihyunl2 changed the title Segmentation fault from snapshotter.cpp Issues in snapshotter.cpp Jul 26, 2022
@jihyunl2
Copy link
Author

Line 801: if (future_result == rclcpp::FutureReturnCode::SUCCESS)
doesn't seem to make sense to me. Shouldn't it be != instead? If not, could you explain why? Thanks in advance.

@jihyunl2 jihyunl2 changed the title Issues in snapshotter.cpp Seg fault issues in snapshotter.cpp Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jihyunl2