Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update configs types #1344

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: update configs types #1344

merged 2 commits into from
Dec 11, 2024

Conversation

gurgelio
Copy link
Contributor

Not all config keys were included in the Record, only the recommended ones.

Copy link
Collaborator

@brettz9 brettz9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... I think just the suggested nit fixes and we should be good to go here...

src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
Co-authored-by: Brett Zamir <brettz9@yahoo.com>
@gurgelio
Copy link
Contributor Author

I've just fixed those typos

@brettz9 brettz9 merged commit d2c6040 into gajus:main Dec 11, 2024
5 checks passed
Copy link

🎉 This issue has been resolved in version 50.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brettz9
Copy link
Collaborator

brettz9 commented Dec 11, 2024

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants