-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announcement of Discord chat server #601
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thoughts on using the new GitHub discussions tool? It seems to meet this need, has searchable threads, and doesn't require leaving GitHub. |
@neverendingqs : I sympathize with the concern, but I'm inclined to keep using the Discord server as the chat nature suggests and facilitates the more temporal and tentative nature of the assistance offered. I don't want to tacitly suggest that by our accepting them, all discussions will necessarily get a response or have action taken. Anything of importance should be filed as an issue. |
@brettz9 Unfortunately, I can't join discord at work, and there is no discussion forum outside of discord. Hopefully, this place is okay. I wonder if it would be possible to lint an issue that tsserver reports. Overall, my goal is to remove the need for the tsc/tsserver steps in compilation or checks. Which means I need the eslint rules to catch something like this as an error. /** @type {string} **/
let x = 7; My current eslint.config.js // @ts-check
//
import eslint from '@eslint/js';
import tseslint from 'typescript-eslint';
export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.recommended,
); and my .eslintrc.json
Using the latest of jsdoc and this plugin, and eslint. All configured today. |
@coffee-coder99 : Take a look at |
@brettz9 thank you for helping. It appears no 'type-checks' are done. Is there something I could be missing? /**
* @returns {string}
*/
function yesterday() {
const date = new Date();
date.setDate(date.getDate() - 1);
return formatDate(date);
} This is only showing a warning for missing returns description. I have reconfigured everything to use .eslintrc.cjs
The original case, still shows no type issues either. /** @type {string} **/
let x = 7;
console.log(x); |
I guess what I'm asking is if tsc/tsserver MUST be utilized in conjunction, or if there is a way to run this type of analysis with only eslint. |
Re: the rule, please try this instead: 'jsdoc/no-restricted-syntax': ['error', { contexts: [
{
context: 'any',
comment: 'JsdocBlock:has(JsdocTag[tag=type])'
}
] }] I am not personally familiar with tools which run tsc through eslint. It looks like https://www.npmjs.com/package/eslint-plugin-tsc might do this, but I haven't tried it. Most projects use both since tsc does its own checking independent from normal ESLint rules, and the prominent TypeScript plugins which exist try to enhance rather than replace tsc. Their output is at least visible together in tools like Visual Studio Code though. |
Just an announcement...
I've also filed jsdoc/jsdoc#1808 to invite jsdoc proper to get involved and possibly take ownership. (I thought a chat server for
eslint-plugin-jsdoc
, while possible, would be better under a more broad jsdoc umbrella. Note there is an#eslint-plugin-jsdoc
-specific chat room, though perhaps we can split that further as needed into help and development rooms).As mentioned there, no promises at all on necessarily even replying to questions or comments there, but thought there should be a space.
You can join by visiting https://discord.gg/kFFy3nc
And if I didn't formally announce it here before, there is also a jsdoc awesome list I started at https://github.com/brettz9/awesome-jsdoc .
The text was updated successfully, but these errors were encountered: