Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on new branch #57

Open
c-vetter opened this issue Nov 29, 2019 · 4 comments
Open

Crashes on new branch #57

c-vetter opened this issue Nov 29, 2019 · 4 comments

Comments

@c-vetter
Copy link

When creating a new branch, which consequently has no remote branch, I get this behavior:

npx gitdown ./README_src.md --output-file ./README.md
Unhandled rejection Error: Branch ("issue-36") definition does not exist in the config.

This has previously been noted in #27 but closed without change. I think, this is undesirable behavior.

I'd like to get a more understandable error message instead of an exception, if failure is the expected behavior for new branches. Ideally, I'd like this to work for new branches as well, but since git itself won't setup tracking without the remote branch, that's probably out of scope for gitdown.

It would be nice to get a warning if no URLs are needed, but an error when this prevents building.

Also, when the README file cannot be updated, gitdown should fail with a non-zero exit code. My use-case is that gitdown updates my README.md from a README.src.md via commit hook. If that goes through despite not doing its work, that is a recipe for disaster.

@gajus
Copy link
Owner

gajus commented Nov 29, 2019

Are you available to contribute?

@c-vetter
Copy link
Author

c-vetter commented Dec 2, 2019

Yes, starting today 🙂

@ALRubinger
Copy link

Hey, y'all.

Would love to use this; am running into the same issue here. I also have my branches on both my origin and upstream remotes:

gitdown ./getting-started-ssi-service/GETTING_STARTED_SSI_SERVICE.md --output-file ./build/GETTING_STARTED_SSI_SERVICE.md
/home/alr/.nvm/versions/node/v17.3.0/lib/node_modules/gitdown/node_modules/gitinfo/dist/gitinfo.js:100
     throw new Error('Branch ("' + branchName + '") definition does not exist in the config.');
           ^

Error: Branch ("jbang-gitdown") definition does not exist in the config.
   at Object.gitinfo.getRemoteUrl (/home/alr/.nvm/versions/node/v17.3.0/lib/node_modules/gitdown/node_modules/gitinfo/dist/gitinfo.js:100:13)
   at Object.gitinfo.getUsername (/home/alr/.nvm/versions/node/v17.3.0/lib/node_modules/gitdown/node_modules/gitinfo/dist/gitinfo.js:132:53)
   at Object.gitinfo.getGithubUrl (/home/alr/.nvm/versions/node/v17.3.0/lib/node_modules/gitdown/node_modules/gitinfo/dist/gitinfo.js:51:44)

Would be great to run this locally without regard to what's going on with my remote branches.

Thanks!

@ALRubinger
Copy link

Note: gitdown succeeds when my remote branch is tracked in .gitconfig:

[branch "jbang-gitdown"]
	remote = origin
	merge = refs/heads/jbang-gitdown

So that's a workaround for those following. Still I'd like to avoid this error when the remote branch is not being tracked in this way; IMO the operation should simply run off the local filesystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants