Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve proxy connection error handling #1

Closed
gajus opened this issue Apr 26, 2019 · 1 comment
Closed

Improve proxy connection error handling #1

gajus opened this issue Apr 26, 2019 · 1 comment
Labels
enhancement New feature or request released

Comments

@gajus
Copy link
Owner

gajus commented Apr 26, 2019

Currently if the connection to proxy cannot be established/ error response is received, then global-agent just dies with an uncaught exception.

This issue requires building test cases for failing proxy and gracefully handling those scenarios.

Example of connection error handling in https://github.com/koichik/node-tunnel/blob/5fb2fb424788597146b7be6729006cad1cf9e9a8/lib/tunnel.js#L150-L169.

@gajus gajus added the enhancement New feature or request label Apr 26, 2019
@gajus gajus closed this as completed in 02086d9 Jun 21, 2019
@gajus
Copy link
Owner Author

gajus commented Jun 21, 2019

🎉 This issue has been resolved in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

1 participant