This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Feat/is middleware signer #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Jan 27, 2021
gakonst
reviewed
Jan 27, 2021
ethers-providers/src/provider.rs
Outdated
Comment on lines
341
to
349
| // deserialize the signature from its {r, s, v} components. | ||
| let v = sig[128..130].parse::<u64>().unwrap(); | ||
| let sig_json = format!( | ||
| r#"{{"r": "0x{}", "s": "0x{}", "v": {}}}"#, | ||
| &sig[..64], | ||
| &sig[64..128], | ||
| v | ||
| ); | ||
| Ok(serde_json::from_str(&sig_json).map_err(ProviderError::SerdeJson)?) |
There was a problem hiding this comment.
Instead of this, should we instead use the Signature TryFrom?
let sig = hex::decode(sig)?
Ok(Signature::try_from(sig)?)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It would be useful to have a way to know if a middleware can sign data.
A way to know if one of the two is true:
SignerMiddlewareeth_signcallSolution
is_signermethod to theMiddlewaretraitis_signeris always true forSignerMiddlewareis_signeris true if the JSON-RPC provider has an unlocked key and supportseth_signcall