Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: rebase to master for onbjerg's ast #1943

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Conversation

iFrostizz
Copy link
Contributor

Motivation

Following up on onbjerg's PR: #1567 to make the files play nicely with the master branch, the merge from master to the ast branch was deleting some files on the last commit.

PR Checklist

  • Check for foundry dependencies (coverage?)

onbjerg and others added 3 commits December 16, 2022 12:27
rebase with master
squash ast

test: fix ast test path

refactor: some clean up

docs: correct some docs

fix: ast serde behavior

test: add more ast tests

Pulled in from https://github.com/ethereum/solidity

test: improve ast test error messages

fix: more serde behavior

fix: more serde behavior

test: add documentation tests

feat: stronger types

fix: more type juggling

docs: fix rustdoc links

fix: type names for older compilers

docs: a bit more docs

test: remove legacy tests

chore: remove some todos

add missing ast

correct source

uncomment etherscan test

yul function call

rebase
@iFrostizz iFrostizz changed the title F/ast fix: rebase to master for onbjerg's ast Dec 16, 2022
@mattsse
Copy link
Collaborator

mattsse commented Dec 16, 2022

@mattsse @onbjerg let's merge Frostiz's PR on Bjerg's PR and get this in? does it get us tangible improvements on foundry that we should prioritize?

as discussed #1567

let's try this, but before we merge let's ensure this doesn't cause issues in foundry.

can you open a PR on foundry with a patch to check this first?

@iFrostizz
Copy link
Contributor Author

@mattsse @onbjerg let's merge Frostiz's PR on Bjerg's PR and get this in? does it get us tangible improvements on foundry that we should prioritize?

as discussed #1567

let's try this, but before we merge let's ensure this doesn't cause issues in foundry.

can you open a PR on foundry with a patch to check this first?

see here: foundry-rs/foundry#3899

@iFrostizz
Copy link
Contributor Author

waiting for foundry-rs/foundry#3899 and this to be merged to master in order to create a new PR for the fixes about the coverage on foundry's side

@iFrostizz
Copy link
Contributor Author

Bump friends

@gakonst
Copy link
Owner

gakonst commented Dec 22, 2022

Sorry for being late! Vacation time etc., thanks for the understanding :)

@gakonst gakonst merged commit d553111 into gakonst:master Dec 22, 2022
@mattsse mattsse mentioned this pull request Dec 22, 2022
4 tasks
@iFrostizz
Copy link
Contributor Author

All good ! Merry Christmas ⛄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants