This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
tests: use sepolia #1989
Merged
tests: use sepolia #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
suggested changes
Dec 30, 2022
.github/workflows/ci.yml
Outdated
| @@ -12,7 +12,7 @@ name: Tests | |||
| env: | |||
| ETHERSCAN_API_KEY_ETHEREUM: I5BXNZYP5GEDWFINGVEZKYIVU2695NPQZB | |||
| ETHERSCAN_API_KEY_CELO: B13XSMUT6Q3Q4WZ5DNQR8RXDBA2KNTMT4M | |||
| GOERLI_PRIVATE_KEY: "fa4a1a79e869a96fcb42727f75e3232d6865a82ea675bb95de967a7fe6a773b2" | |||
| SEPOLIA_PRIVATE_KEY: "fa4a1a79e869a96fcb42727f75e3232d6865a82ea675bb95de967a7fe6a773b2" | |||
There was a problem hiding this comment.
let's keep goerli as well
we could also switch to gh secrets
There was a problem hiding this comment.
do you mean we shouldn't change to sepolia at all, or just keep the env var name as goerli?
There was a problem hiding this comment.
problem is that tests are flaky with goerli
gakonst
suggested changes
Dec 30, 2022
.github/workflows/ci.yml
Outdated
| @@ -1,288 +1,283 @@ | |||
| on: | |||
There was a problem hiding this comment.
giga nit but pls configure your editor to not change the formatting on these files :D or let's do it in a separate PR intentionally
There was a problem hiding this comment.
idk why it formats on search and replace, that was unintentional
gakonst
reviewed
Dec 30, 2022
ethers-providers/src/lib.rs
Outdated
| @@ -756,16 +758,14 @@ pub mod test_provider { | |||
| } | |||
|
|
|||
| impl TestProvider { | |||
| pub fn new(keys: &'static [&'static str], network: &str) -> Self { | |||
| Self { keys: Mutex::new(keys.iter().cycle()), network: network.to_owned() } | |||
| pub fn new(network: impl Into<String>) -> Self { | |||
There was a problem hiding this comment.
i'd like to keep this around so a consumer can specify providers w/ other infura keys in the future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
goerli moment
Solution
add sepolia to test provider and use it
fauceted from https://web.getlaika.app/faucets
PR Checklist