This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(core): fix geth --init temp dir race condition #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* previously, if multiple instances of geth were spawned concurrently, only one directory would be used to populate geth's genesis.json. this can lead to a race condition where the genesis.json would be re-written by a second instance, before the first instance reads the genesis.json for populating its db and genesis block with the geth --init command. this was possible because directory returned by std::env::temp_dir() is often shared * fixes the race condition by using tempfile::tempdir(), which creates a unique directory per call to tempdir()
mattsse
approved these changes
Jan 21, 2023
|
just added: [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
tempfile = { version = "3.3.0", default-features = false }to fix the unused dependency |
18 tasks
gakonst
approved these changes
Jan 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, if multiple instances of geth were spawned concurrently, only one directory would be used to populate geth's
genesis.json. This can lead to a race condition where thegenesis.jsonwould be re-written by a second instance, before the first instance reads thegenesis.jsonfor populating its db and genesis block with thegeth --initcommand. this was possible because directory returned bystd::env::temp_dir()is often shared.Solution
This fixes the race condition by using
tempfile::tempdir(), which creates a unique directory per call totempdir().PR Checklist