Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(abigen): builtin trait derives #2170

Merged
merged 7 commits into from
Feb 21, 2023

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Feb 20, 2023

Motivation

Fixes #2166

Explained in #2166 (comment)

Solution

  1. Add a function that conditionally appends Default and others to the derive list + add multiple versions of seaport in tests
  • also use this function for the generic call/error/event enum
  1. Refactor derive(EthDisplay) to also take the tuple length into account
  2. Improve type detection in ethers-contract-derive due to missing some types + add exhaustive test.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks way cleaner.

lgtm, given that tests still pass

@gakonst gakonst merged commit 3732de8 into gakonst:master Feb 21, 2023
@gakonst
Copy link
Owner

gakonst commented Feb 21, 2023

Thank you @DaniPopes 🤝

@DaniPopes DaniPopes deleted the fix/abigen-builtin-derives branch February 21, 2023 07:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seaport 1.3 ABI-gen not implementing traits
3 participants