This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This adds async helper functions for compiling contracts and setting up
geth
organache
.Using the async
compile_and_launch_ganache
will only take as long as the longest running command (solc
,ganache-cli
).This will shave off the solidity compile time for the updated examples, because this in those cases the compile time is very short. And it will shave off the
~1.8s
it takes to launch ganache for those cases wheresolc
takes longer than that.Solution
Feature gate a
setup
module inethers-core
that simply runstokio::task::blocking
for the commands (solc
,geth
,ganache
) and join those task when usingcompile_and_launch_ganache
orcompile_and_launch_geth
.By default the
setup
feature of theethers-core
crate is enabled inethers
exposing those helper functions from theethers::util
module.