This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(signers): add Wallet::encrypt_keystore #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xZerohero
changed the title
0xZerohero
changed the title
0xZerohero
changed the title
DaniPopes
suggested changes
Jul 11, 2023
DaniPopes
approved these changes
Jul 25, 2023
aathan
pushed a commit
to aathan/ethers-rs
that referenced
this pull request
Jul 27, 2023
* feat(signers): add Wallet::encrypt_keystore * chore(signers): use a non-random private key * chore(signers): fix comment * chore(signers): fix encrypted_json_keystore_from_pk test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This function is similar to Wallet::new_keystore, but instead of adding the a random private key to the file, it adds a key passed as a parameter.
This is handy when you want to safe an existing private key in an encrypted file.
This can also help with the implementation of foundry-rs/foundry#5057
Solution
PR Checklist