Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: skip checksums on windows for now #2553

Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 12, 2023

ref foundry-rs/foundry#5601

alloy-rs/svm-rs#95

on windows solc downloads are zip files, the checksums are for the zip files
however, we extract the exe and are hashing this file in ethers-solc

this disables the checksum until we can properly do this, this will make it easier for windows users to use forge without redownloading all files over and over again

Copy link
Contributor

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof good catch, this slows down windows users a ton

@DaniPopes DaniPopes merged commit 8e50e43 into gakonst:master Aug 13, 2023
19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants