You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Describe the solution you'd like
I've found 17 chains with a multicall deployment that are supported as Chain in ethers-core, but not included in MULTICALL_SUPPORTED_CHAIN_IDS, using this script. There are even more chains that are not supported as Chain.
I propose to add at least the first group of 17 chains to MULTICALL_SUPPORTED_CHAIN_IDS.
Describe alternatives you've considered ethers-rs can also stop supporting this constant, either before adding these 17 chains (forcing everyone to use custom constructor if they want any of these chains) or after (saying "okay, here is the update, but it's going to be the last one, use custom constructor from now").
I'll be happy to implement any version of this (17/(17 + 81) chains, with deprecation or not), but need direction from maintainers here.
Additional context
17 chains that are currently not available (-1, Arbitrum Sepolia is already being added in an open PR).
Is your feature request related to a problem? Please describe.
It seems like
MULTICALL_SUPPORTED_CHAIN_IDS
got out of sync with the list of Multicall deployments. There are 3 PRs in the few months adding new chains: #2574, #2705 (mine), #2641.Describe the solution you'd like
I've found 17 chains with a multicall deployment that are supported as
Chain
inethers-core
, but not included inMULTICALL_SUPPORTED_CHAIN_IDS
, using this script. There are even more chains that are not supported asChain
.I propose to add at least the first group of 17 chains to
MULTICALL_SUPPORTED_CHAIN_IDS
.Describe alternatives you've considered
ethers-rs
can also stop supporting this constant, either before adding these 17 chains (forcing everyone to use custom constructor if they want any of these chains) or after (saying "okay, here is the update, but it's going to be the last one, use custom constructor from now").I'll be happy to implement any version of this (17/(17 + 81) chains, with deprecation or not), but need direction from maintainers here.
Additional context
17 chains that are currently not available (-1, Arbitrum Sepolia is already being added in an open PR).
81 chains that are not supported as
Chain
: https://gist.github.com/sevazhidkov/3579733246752c36aaa959613fdbe629The text was updated successfully, but these errors were encountered: