This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
chore: remove cyclical dependencies #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gakonst
commented
Aug 27, 2021
•
gakonst
commented
- Removes any cyclical dependencies from the code
tests using higher-rank crates are temporarily disabled
move over the test using middleware to ethers-middleware
gakonst
force-pushed
the
chore/simplify-release
branch
from
b4492cd
to
a0c5d94
Compare
the test had the same private key with an existing middleware test, causing potential nonce reuses it now also uses a different storage contract, so we had to change it to use u256 instead of string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.