feat: add etherscan client crate #486
Conversation
mattsse
force-pushed
the
matt/add-ethers-etherscan
branch
from
dfb1c06
to
e45660a
Compare
mattsse
force-pushed
the
matt/add-ethers-etherscan
branch
from
e45660a
to
9efca0b
Compare
| #[ignore] | ||
| async fn can_verify_contract() { | ||
| // TODO this needs further investigation |
There was a problem hiding this comment.
Is this working now or does it still require more investigation?
There was a problem hiding this comment.
still get this response instantly, so I think I messed up the payload somehow, but tried various, alternatives like numbers as strings, etc.., will need to take a closer look at dapptools itself or any other etherscan client
Response {
status: "0",
message: "NOTOK",
result: "Error!",
},
| .parse() | ||
| .unwrap(); | ||
| let compiler_version = "v0.5.17+commit.d19bba13"; | ||
| let constructor_args = "0x000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000005f5e1000000000000000000000000000000000000000000000000000000000000000007596179537761700000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000035941590000000000000000000000000000000000000000000000000000000000"; |
There was a problem hiding this comment.
I wonder if we should move BaseContract to ethers-core now to encode constructor arguments in a nice way
There was a problem hiding this comment.
that'd be useful, I think we touched on abstracting functions as a trait via abigen! some time ago, I think it makes sense to follow up on this and move all general abstractions to core.
| #[serde(flatten)] | ||
| other: T, |
| /// let meta = client | ||
| /// .contract_source_code("0xBB9bc244D798123fDe783fCc1C72d3Bb8C189413".parse().unwrap()) | ||
| /// .await?; |
There was a problem hiding this comment.
Should we also compile this with Solc? Or provide some helper way to convert this to a CompiledContract
There was a problem hiding this comment.
the etherscan api doesn't seem to provide the bytecode directly, however it is present in the html reponse with div[id=verifiedbytecode2] -.-
Additional tooling to instantly compile this is probably useful, I'll add this to the tracking issue
mattsse
force-pushed
the
matt/add-ethers-etherscan
branch
from
0329491
to
2b72e39
Compare
Motivation
Add etherscan.io client,
Ref #485
Solution
PR Checklist