Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: method deduplication #619

Merged
merged 4 commits into from
Nov 27, 2021
Merged

fix: method deduplication #619

merged 4 commits into from
Nov 27, 2021

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 25, 2021 •
edited
Loading

Motivation

close #608

Solution

  • num(overloaded) > 3 -> always use index, otherwise try to aliase using diff
  • handle name conflicts properly like log(address p0) and log(unit p0) and fallback to idex based aliasing
  • an overloaded function without any inputs will always get the suffix 0

PR Checklist

  • Added Tests
  • Added Documentation

@gakonst gakonst mentioned this pull request Nov 27, 2021
Merged
@mattsse mattsse marked this pull request as ready for review November 27, 2021 12:27
@gakonst gakonst merged commit 9b6cc37 into gakonst:master Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abigen failure to deduplicate methods
2 participants
@mattsse @gakonst