Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat(etherscan, middleware): implement gas endpoints and use in oracle middleware #621

Merged
merged 12 commits into from
Nov 27, 2021

Conversation

shekhirin
Copy link
Contributor

@shekhirin shekhirin commented Nov 25, 2021

Motivation

#485

PR Checklist

  • Add free tier gastracker/gas_estimate and gastracker/gas_oracle methods for corresponding endpoints
  • Use Etherscan::gas_oracle for oracle middleware
  • Run at most 1 etherscan test per 250ms and make all etherscan tests serial instead of parallel so we don't get rate limited
  • Add separate etherscan API token for Celo tests so we don't get rate limited

@shekhirin shekhirin force-pushed the feat/etherscan-gas-n-middleware branch from 0c87e7f to ee5f539 Compare November 25, 2021 06:25
@shekhirin shekhirin force-pushed the feat/etherscan-gas-n-middleware branch 5 times, most recently from 2db3eeb to b4410e0 Compare November 25, 2021 08:33
@shekhirin shekhirin force-pushed the feat/etherscan-gas-n-middleware branch from b4410e0 to 7e45372 Compare November 25, 2021 08:36
@shekhirin shekhirin force-pushed the feat/etherscan-gas-n-middleware branch from b1965df to ab8b405 Compare November 25, 2021 09:05
@shekhirin shekhirin marked this pull request as ready for review November 25, 2021 09:14
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work.

@gakonst gakonst merged commit dd2c589 into gakonst:master Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants