Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: source parsing for local paths #633

Merged
merged 1 commit into from
Nov 29, 2021
Merged

fix: source parsing for local paths #633

merged 1 commit into from
Nov 29, 2021

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 29, 2021

Motivation

followup on #631 that prevents path resolution while parsing the path

Solution

don't canonicalize local paths like ./testdata/console.json in Source::parse, resolving paths for Source::Local happens at a later stage at Source::get

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

gakonst
gakonst approved these changes Nov 29, 2021
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll get it right eventually

@gakonst gakonst merged commit 5dfc1bd into gakonst:master Nov 29, 2021
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
@calldata
fix typo (gakonst#633)
1be3bab
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @gakonst