This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: check all import styles #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/fix-import-statement-parsing
branch
from
9021e2d
to
867d13f
Compare
gakonst
approved these changes
Nov 29, 2021
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Nov 30, 2021
includes gakonst/ethers-rs#634 which fixes #188
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
includes gakonst/ethers-rs#634 which fixes foundry-rs/foundry#188
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
includes gakonst/ethers-rs#634 which fixes foundry-rs/foundry#188
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
foundry-rs/foundry#188 I believe this happened because not all import styles were actually supported
Solution
check all variants when scanning import statements
PR Checklist