This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(providers): Log methods for PendingTransaction #884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I frequently want to print the transaction hash of a pending transaction before it is mined. Currently, this is pretty verbose, because you need a let binding for the transaction:
Solution
Add two convenience methods on the
PendingTransaction<_>
type,log()
andlog_msg()
.Another approach that isn't just for printing might be to add a method to
PendingTransaction<_>
that returns(TxHash, Self)
, which would turn the above into:PR Checklist