Skip to content

Commit 6729113

Browse files
committed
feat: opt code
1 parent 50fe5e9 commit 6729113

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

packages/core/src/animation/Animator.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ export class Animator extends Component {
604604
this._fireAnimationEventsAndCallScripts(layerIndex, srcPlayData, state, lastClipTime, lastPlayState, playCostTime);
605605

606606
if (transition) {
607-
// actualCostTime = playCostTime / playSpeed
607+
// Remove speed factor, use actual cost time
608608
const remainDeltaTime = deltaTime - playCostTime / playSpeed;
609609
remainDeltaTime > 0 && this._updateState(layerIndex, layerData, layer, remainDeltaTime, aniUpdate);
610610
}

packages/core/src/animation/AnimatorController.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export class AnimatorController extends ReferResource {
5454
* @param name - The name of the parameter
5555
* @param defaultValue - The default value of the parameter
5656
*/
57-
addParameter(name: string, defaultValue?: AnimatorControllerParameterValue) {
57+
addParameter(name: string, defaultValue?: AnimatorControllerParameterValue): AnimatorControllerParameter {
5858
if (this._parametersMap[name]) {
5959
console.warn(`Parameter ${name} already exists.`);
6060
return null;

packages/loader/src/AnimatorControllerLoader.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,7 @@ class AnimatorControllerLoader extends Loader<AnimatorController> {
100100
animatorController.addLayer(layer);
101101
});
102102
parameters.forEach((parameterData) => {
103-
const parameter = new AnimatorControllerParameter();
104-
parameter.name = parameterData.name;
105-
parameter.defaultValue = parameterData.defaultValue;
106-
animatorController.addParameter(parameter);
103+
animatorController.addParameter(parameterData.name, parameterData.defaultValue);
107104
});
108105
Promise.all(promises).then((clipData) => {
109106
clipData.forEach((data) => {

0 commit comments

Comments
 (0)