Skip to content

Commit bd09bc8

Browse files
committed
refactor: opt update func name
1 parent 4b7bfab commit bd09bc8

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

packages/core/src/Renderer.ts

+5-3
Original file line numberDiff line numberDiff line change
@@ -334,9 +334,8 @@ export class Renderer extends Component implements IComponentCustomClone {
334334
this._distanceForSort = Vector3.distanceSquared(boundsCenter, cameraPosition);
335335
}
336336

337-
// Update once per frame per renderer, not influenced by batched
338337
if (this._renderFrameCount !== this.engine.time.frameCount) {
339-
this._updateRendererShaderData(context);
338+
this._update(context);
340339
}
341340

342341
this._render(context);
@@ -411,7 +410,10 @@ export class Renderer extends Component implements IComponentCustomClone {
411410
*/
412411
_batch(elementA: SubRenderElement, elementB?: SubRenderElement): void {}
413412

414-
protected _updateRendererShaderData(context: RenderContext): void {
413+
/**
414+
* Update once per frame per renderer, not influenced by batched.
415+
*/
416+
protected _update(context: RenderContext): void {
415417
const { layer } = this.entity;
416418
this._rendererLayer.set(layer & 65535, (layer >>> 16) & 65535, 0, 0);
417419
}

packages/core/src/mesh/SkinnedMeshRenderer.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ export class SkinnedMeshRenderer extends MeshRenderer {
154154
this._blendShapeWeights && (target._blendShapeWeights = this._blendShapeWeights.slice());
155155
}
156156

157-
protected override _updateRendererShaderData(context: RenderContext): void {
157+
protected override _update(context: RenderContext): void {
158158
const { skin } = this;
159159
if (skin?.bones.length > 0) {
160160
skin._updateSkinMatrices(this);
@@ -210,7 +210,7 @@ export class SkinnedMeshRenderer extends MeshRenderer {
210210
}
211211
}
212212

213-
super._updateRendererShaderData(context);
213+
super._update(context);
214214
}
215215

216216
/**

packages/core/src/particle/ParticleRenderer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ export class ParticleRenderer extends Renderer {
192192
}
193193
}
194194

195-
protected override _updateRendererShaderData(context: RenderContext): void {
195+
protected override _update(context: RenderContext): void {
196196
const generator = this.generator;
197197
generator._update(this.engine.time.deltaTime);
198198

0 commit comments

Comments
 (0)