Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base url is not replaced correctly #9

Open
maxisam opened this issue May 21, 2020 · 4 comments · May be fixed by #10
Open

base url is not replaced correctly #9

maxisam opened this issue May 21, 2020 · 4 comments · May be fixed by #10

Comments

@maxisam
Copy link

maxisam commented May 21, 2020

if base url like

<base href="https://www.test.com/">

it doesn't work correctly. There is an extra ">" in the result.

@maxisam maxisam linked a pull request May 21, 2020 that will close this issue
@hheexx
Copy link

hheexx commented Jun 17, 2020

Thanks for fixing!

Is this project abandoned?

@hheexx
Copy link

hheexx commented Jun 17, 2020

Looks like your regex is not replacing anything in my case...

@maxisam
Copy link
Author

maxisam commented Jun 17, 2020

Looks like your regex is not replacing anything in my case...

ah...i don't know it works on mine. what's your url?

@hheexx
Copy link

hheexx commented Jun 17, 2020

Something like: https://cityexpert.rs/izdavanje/stan/38438/dvosoban-arhimandrita-gerasima-zelica-cukarica.

I fixed it with just removing duplicate character:
content = content.Replace("", "<base href="/">"); //old
content = content.Replace("", "<base href="/""); //fixed

I'm not sure is this fuction or regex more performant. We should test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants