nodejs / gulp ContextifyScript error in yarn build

[peterjc]

I have been seeing recent planemo test runs fail, during setup of Galaxy master branch (outside of planemo). The change happened about one month ago, noticed by a weekly cron job on TravisCI (my code did not change):

https://travis-ci.org/peterjc/galaxy_blast/jobs/370183281 (four weeks ago), worked

https://travis-ci.org/peterjc/galaxy_blast/jobs/373115719 (three weeks ago), same commit, failed as below
https://travis-ci.org/peterjc/galaxy_blast/jobs/375977735 (two weeks ago), same commit, failed as below

https://travis-ci.org/peterjc/galaxy_blast/jobs/377737346 (10 days ago), different tool commit
https://travis-ci.org/peterjc/galaxy_blast/jobs/378809015 (one week ago), different tool commit
https://travis-ci.org/peterjc/galaxy_blast/jobs/381650523 (today), different tool commit

$ bash scripts/common_startup.sh --no-create-venv --dev-wheels
Initializing config/migrated_tools_conf.xml from migrated_tools_conf.xml.sample
Initializing config/shed_tool_conf.xml from shed_tool_conf.xml.sample
Initializing config/shed_tool_data_table_conf.xml from shed_tool_data_table_conf.xml.sample
Initializing config/shed_data_manager_conf.xml from shed_data_manager_conf.xml.sample
Initializing tool-data/shared/ucsc/builds.txt from builds.txt.sample
Initializing tool-data/shared/ucsc/manual_builds.txt from manual_builds.txt.sample
Initializing static/welcome.html from welcome.html.sample
Requirement already satisfied: pip>=8.1 in /home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages (10.0.1)
Looking in indexes: https://wheels.galaxyproject.org/simple, https://pypi.python.org/simple
Collecting numpy==1.9.2 (from -r requirements.txt (line 4))
  Downloading https://wheels.galaxyproject.org/packages/numpy-1.9.2-cp27-cp27mu-manylinux1_x86_64.whl (10.2MB)
...
The Galaxy client has not yet been built and will be built now.
Installing node into /home/travis/virtualenv/python2.7.14 with nodeenv.
 * Install prebuilt node (10.1.0) ..... done.
 * Appending data to /home/travis/virtualenv/python2.7.14/bin/activate
Installing yarn into /home/travis/virtualenv/python2.7.14 with npm.
/home/travis/virtualenv/python2.7.14/bin/yarn -> /home/travis/virtualenv/python2.7.14/lib/node_modules/yarn/bin/yarn.js
/home/travis/virtualenv/python2.7.14/bin/yarnpkg -> /home/travis/virtualenv/python2.7.14/lib/node_modules/yarn/bin/yarn.js
+ yarn@1.6.0
added 1 package in 0.51s
cd client && yarn install --check-files
yarn install v1.6.0
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@1.1.2: The platform "linux" is incompatible with this module.
info "fsevents@1.1.2" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 44.74s.
cd client && yarn run build
yarn run v1.6.0
$ NODE_ENV=development gulp stage-libs && concurrently "yarn run style" "yarn run webpack" "yarn run gulp clean && yarn run gulp" && yarn run save-build-hash
gulp[3241]: ../src/node_contextify.cc:628:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' failed.
 1: node::Abort() [gulp]
 2: 0x876c55 [gulp]
 3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [gulp]
 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [gulp]
 5: 0xacd2df [gulp]
 6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [gulp]
 7: 0x3d786768427d
Aborted (core dumped)
error Command failed with exit code 134.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [client] Error 1
ERROR: Galaxy client build failed. See ./client/README.md for more information, including how to get help.

Possibly related to nodejs/node#20285 suggesting a node version problem?

[peterjc]

Cross reference galaxyproject/planemo#803 which looks like a planemo change related to skipping yarn build...

[dannon]

@peterjc Interesting, I'll see if I can reproduce this. In any event, I'll update the related libraries in a PR.

[dannon]

@peterjc Forgot to update this issue again earlier. The problem should be fixed in galaxy's dev and 18.05 releases (and, master, as soon as the release is official). (see https://github.com/galaxyproject/galaxy/blob/dev/scripts/common_startup.sh#L240)

[peterjc]

Confirming that testing against the master branch is working again for me now, thanks!

[peterjc]

Cross reference #5972 for the fix itself, pinning the version of node.