Add the CSG Viewer visualization plugin #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martenson @nsoranzo @erasche @bgruening @blankenberg Can this be merged or is there something more I should do? |
|
@galaxybot test this |
|
I'm can not tell about the JS side, the vis side looks good! |
|
@bgruening The JS side works. I recently added a tool that allows you to use an image dataset (png or jpg format) to apply a texture to a shape. Here's a sample using the viewer! ;)
|
|
I am not an expert but this looks solid. Thanks @gregvonkuster ! |
martenson
added a commit
that referenced
this pull request
Dec 16, 2015
Add the CSG Viewer visualization plugin
|
@martenson @bgruening Thanks for the reviews and the merge - much appreciated! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on conversations here:
#1191 (comment)