Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!include: gravity.yml breaks Galaxy #78

Closed
natefoo opened this issue Oct 12, 2022 · 1 comment
Closed

!include: gravity.yml breaks Galaxy #78

natefoo opened this issue Oct 12, 2022 · 1 comment

Comments

@natefoo
Copy link
Member

natefoo commented Oct 12, 2022 •
edited
Loading

Because the !include directive support is only implemented in Gravity, it works fine with Gravity, but when Galaxy tries to load galaxy.yml, it blows up. I implemented the include support but then didn't end up actually needing it so I guess that didn't get tested...

So we should either make Galaxy capable of parsing it (it doesn't actually need to perform the include), or we should drop support for it entirely. You could also imagine having separate Galaxy and Gravity configs, and adding a galaxy_config_file param to Gravity for locating the Galaxy config corresponding to a given Gravity config.
@natefoo natefoo mentioned this issue Oct 20, 2022
Merged
@natefoo
Copy link
Member Author

natefoo commented Oct 28, 2022

Fixed in #80

@natefoo natefoo closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@natefoo