Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing methods on setup after upgrading to 4.4.0 #841

Closed
ncuesta opened this issue Mar 26, 2019 · 4 comments
Closed

Missing methods on setup after upgrading to 4.4.0 #841

ncuesta opened this issue Mar 26, 2019 · 4 comments
Assignees

Comments

@ncuesta
Copy link

ncuesta commented Mar 26, 2019

Hi, I started having an issue with some missing methods right after I upgraded the gem to its 4.4.0 version (in a Rails 5.2.2.1 don't think that's relevant, though) from 4.2.0.

I have this initializer:

# config/initializers/ckeditor.rb
Ckeditor.setup do |config|
  config.assets_languages = ['es', 'en']
  config.assets_plugins = ['image']
end

After upgrading the gem, I started getting this error:

[APP_ROOT_PATH]/config/initializers/ckeditor.rb:2:in `block in <main>': undefined method `assets_languages=' for Ckeditor:Module
Did you mean?  asset_path= (NoMethodError)
	from [GEM_ROOT_PATH]/ckeditor-4.4.0/lib/ckeditor.rb:108:in `setup'
	from [APP_ROOT_PATH]/config/initializers/ckeditor.rb:1:in `<main>'
[...lengthy backtrace...]

which clearly indicates that there is no such method asset_languages= (nor assets_plugins=, already checked) in the Ckkeditor module.

Digging around, I found that the mattr_accessors that generated these methods have been removed in 36a6fcb, but I can't seem to find any reasons for the removal or how can we should specify those options now.

I apologize in advance if I'm missing something that's already documented somewhere, but I'm not finding any info regarding this API change.

Thanks for your time!
Cheers,
Nahuel.

@fbukevin
Copy link

Got the same error as well.

@patricklindsay
Copy link
Collaborator

Use 4.3.0 for now.

4.4.0 was released which removes Ckeditor assets but this should really have been part of v5.

cc @galetahub

@galetahub
Copy link
Owner

Fixed, the release version 4.4.0 has already renamed to 5.0.0 version. So use 4.3.0 version for now without risk for an update

@gaetanm
Copy link

gaetanm commented Jan 27, 2021

Hi,

Same trouble here. I tried an update from 4.3.0 to 5.1.0 and I have exactly the same issue. What should I do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants