Fixing squid: S1151 Switch clauses should not have too many lines part 3 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gallandarakhneorg
added a commit
that referenced
this pull request
Jun 20, 2016
PR #146 is broking the public behavior of the AttributeValueImpl getters by return "null" value instead of throwing invalud attribute type exception. Signed-off-by: Stéphane Galland <galland@arakhne.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule
squid:S1151 - “""switch case"" clauses should not have too many lines”.
This PR will reduce 70 min of TD.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1151
Please let me know if you have any questions.
Fevzi Ozgul