-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of 3D primitives #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to reflect on the change. Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
upcoming GeomFactory3D Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
template Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
implementation Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Vector3D need isRightHanded() or isLeftHanded()
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
Signed-off-by: Thomas Piotrowski <thomas.piotrowski@utbm.fr>
…sing implementations
Some merges may have introduced inconsistencies in the files. For that reason, I am currently retrieving previous version of sources and copypasting them, keeping only trusted modifications. |
Ok. Get the lastest pushed version. Perhaps I have already fix some points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finished creating some of the 3D primitives equivalent of the 2D primitives. There currently is : Tuple3D / Point3D / Vector3D, and Unmodifiable counterpart, Shape3D, MultiShape3D, Path3D, PathElement3D, PathIterator3D, GeomFactory3D and the like.
The following type have NOT been ported Ellipse, Triangle, Parallelogram, OrientedRectangle, RoundRectangle, since I don't know if they make sense in 3D or would be superseded by other 3D shapes ; and the arcTo method of Path3D because it appeared after the copy was made (may be integrated afterwards).
The test structure have been ported too. Slight work has been made to integrate z coordinate for scarce basic checks. There is a lots of errors, mainly due to Path3D overflowing in the storage of coordinates.
The dfx and ifx implementations of shapes have been placed in appropriate advanced module.
see #47