Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn.runInTerminal set true by default #11

Closed
NN--- opened this issue May 16, 2018 · 3 comments
Closed

yarn.runInTerminal set true by default #11

NN--- opened this issue May 16, 2018 · 3 comments

Comments

@NN---
Copy link

NN--- commented May 16, 2018

I think it is good idea to have yarn.runInTerminal set to true by default like npm.runInTerminal does.
( https://marketplace.visualstudio.com/items?itemName=eg2.vscode-npm-script )

@gamunu
Copy link
Owner

gamunu commented May 16, 2018

I thought the same, I too use the terminal as default. Since it was the default setting for a long time, those users using output window as default will get confused. I'll consider this on next release.

@osya
Copy link

osya commented Jun 1, 2018

The cons of setting "yarn.runInTerminal": true is launching the command Yarn: Terminate Running Yarn Script produces Killing is only supported when the setting "runInTerminal" is "false". So as I understand, if some command produces an ANSI output then it is better to execute it via Terminal (which displays ANSI codes correctly and allows to simply terminate the command) than the vscode-yarn extension. Am I right?

@gamunu
Copy link
Owner

gamunu commented Jun 1, 2018

Yes. right now, there's no way to capture child-process when runInTerminal.

@gamunu gamunu closed this as completed Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants