-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Add TypeScript to supported file extensions? #357
Comments
I'm a bit reluctant as this grammar isn't Typescript compatible. You could us the config.cson to force I guess you've tried the https://github.com/TypeStrong/atom-typescript package? It syncs with Microsoft's vscode grammar so it should be up to date. |
I have, the syntax highlighting is not as good. Also it adds a bunch of bloat and unnecessary features. I guess all I really want is a plain grammar and syntax package. Which your package works wonders for... I'll try out the |
Does this change anything? |
@mattmischuk Not sure. It would mean augmenting the grammar to handle specific typescript features and whilst I imagine this wouldn't be a problem I may be wrong. A lot of elements that are common are scoped as flowtype and I don't want to change these nor do I want to add a new scope. The parser seems interesting but I'm not sure who it's aimed at. I'd imagine most TypeScripters would still use |
I don't see much traction for this at the moment. The Atom team has ported the Microsoft typescript grammar recently and are also working on other initiatives that are better suited to a TypeScript workflow. See https://github.com/atom/language-typescript and https://atom.io/packages/ide-typescript |
Good call, thanks for reviewing this again :) |
I'm using TypeScript, but I want syntax highlighting inside of template strings. It'd be awesome to add TypeScript so that it can have this feature. |
I'm using language-babel for syntax highlighting for TypeScript. There isn't a good package that I've found to date. I usually just manually add the extension in the grammar file locally. But I was wondering if it would be worth while to just create a pull-request. This may conflict with other packages so I thought I would pose this as a question first. Thoughts?
The text was updated successfully, but these errors were encountered: