Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in IsRowTrim / IsColTrim for boolean matrices #654

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Fix bug in IsRowTrim / IsColTrim for boolean matrices #654

merged 2 commits into from
Mar 6, 2020

Conversation

flsmith
Copy link
Collaborator

@flsmith flsmith commented Mar 4, 2020

Fix #653

@flsmith flsmith mentioned this pull request Mar 4, 2020
Closed
james-d-mitchell
james-d-mitchell reviewed Mar 5, 2020
View reviewed changes
gap/elements/boolmat.gi Outdated
for i in [1 .. n - 1] do
for j in [i + 1 .. n] do
for i in [1 .. n] do
for j in Concatenation([1 .. i - 1], [i + 1 .. n]) do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this'll make much difference, but might it not be better to just check if j = i inside the loop here?

@james-d-mitchell james-d-mitchell added the bug-fix A label for PRs that fix a bug. label Mar 5, 2020
@james-d-mitchell james-d-mitchell merged commit 463e59c into semigroups:stable-3.2 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-d-mitchell james-d-mitchell james-d-mitchell left review comments

Assignees
No one assigned
Labels
bug-fix A label for PRs that fix a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flsmith @james-d-mitchell @MT-resource-bot