Various tweaks to the GAP kernel extension code #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
added
3.*
enhancement
|
@fingolfin This is very welcome, but something is not correct, I don't have time to check carefully now, but it looks like loading and saving of workspaces is broken in this PR. |
This used to return a GAP object in an inconsistent state: an immutable list containing mutable lists.
If converter->unconvert allocates new objects, this could otherwise lead to a GC crash
First off, whether the plist is immutable or not does not matter anyway, as the tnum is discarded. Secondly, on the GAP level, Objectify rejects immutable lists; while the check for that is currently done on the GAP language level, it might in the future be done on the kernel level, too; so better to play it safe. Also, don't bother to retype to fancy plist TNUMs like T_PLIST_TAB_RECT, as they will be discarded.
|
Fixed |
|
Thanks! @fingolfin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.