Diffs in tests under GAP stable-4.9 branch

[olexandr-konovalov]

When all packages are loaded, there are diffs in the tests: see e.g. https://travis-ci.org/gap-system/gap-docker-pkg-tests-stable-4.9/jobs/392042851

testing: /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/chapter-12.tst
     268 ms (268 ms GC) and 61.0KB allocated for chapter-12.tst
testing: /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/chapter-3.tst
    1084 ms (304 ms GC) and 115MB allocated for chapter-3.tst
testing: /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/chapter-4.tst
   21656 ms (2028 ms GC) and 2.08GB allocated for chapter-4.tst
testing: /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/chapter-5-a.tst
    6392 ms (652 ms GC) and 737MB allocated for chapter-5-a.tst
testing: /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/chapter-5-b.tst
    2228 ms (376 ms GC) and 222MB allocated for chapter-5-b.tst
testing: /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/cp.tst
########> Diff in /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/cp.tst:67
# Input is:
IsConjugate(GrigorchukGroup,pairs[1][1][1],pairs[1][1][2]);
# Expected output:
#I  Init FRBranchGroupConjugacyData
#I  Finished Init FRBranchGroupConjugacyData
true
# But found:
#I  Init FRBranchGroupConjugacyData
Error, List Element: <list>[1] must have an assigned value
########
########> Diff in /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/cp.tst:73
# Input is:
SetFRBranchGroupConjugacyData(GuptaSidkiGroup,
 rec(initial_conj_dic:=NewDictionary([One(GuptaSidkiGroup),One(GuptaSidkiGroup\
)],true),
    Branchstructure:=BranchStructure(GuptaSidkiGroup),
    RepSystem:=List(~.Branchstructure.group,x->PreImagesRepresentative(~.Branc\
hstructure.quo,x)))
 );
# Expected output:
# But found:
Error, List Element: <list>[1] must have an assigned value
########
########> Diff in /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/cp.tst:78
# Input is:
CallFuncList(function(a,t) 
            local G,D,g,h;
            G:= GuptaSidkiGroup;
            D:= FRBranchGroupConjugacyData(G).initial_conj_dic;
            for g in [a,a^2,t,t^2] do
              for h in [a,a^2,t,t^2] do
               if g<>h then
                AddDictionary(D,[g,h],[]);
               fi;
              od;
            od;
            AddDictionary(D,[a,a],[One(G),a,a^2]);
            AddDictionary(D,[a^2,a^2],[One(G),a,a^2]);
            AddDictionary(D,[t,t],[One(G),,,t,,,t^2]);
            AddDictionary(D,[t^2,t^2],[One(G),,,t,,,t^2]);
          end,GeneratorsOfGroup(GuptaSidkiGroup)
  );
# Expected output:
# But found:
#I  Init FRBranchGroupConjugacyData
Error, List Element: <list>[1] must have an assigned value
########
########> Diff in /home/gap/inst/gap-stable-4.9/pkg/fr-2.4.5/tst/cp.tst:96
# Input is:
IsConjugate(GuptaSidkiGroup,GuptaSidkiGroup.1^GuptaSidkiGroup.2,GuptaSidkiGrou\
p.1);
# Expected output:
true
# But found:
#I  Init FRBranchGroupConjugacyData
Error, List Element: <list>[1] must have an assigned value
########
   29660 ms (2528 ms GC) and 3.82GB allocated for cp.tst
-----------------------------------
total     61288 ms (6156 ms GC) and 6.96GB allocated
#I  Errors detected while testing

The full error message in the break loop (when all packages are loaded) is:

gap> IsConjugate(GrigorchukGroup,pairs[1][1][1],pairs[1][1][2]);
#I  Init FRBranchGroupConjugacyData
Error, List Element: <list>[1] must have an assigned value in
  return WreathProductInfo( W ).embeddings[i]; at /home/gap/inst/gap-4.9.1/pkg/rcwa-4.6.1/lib/rcwagrp.gi:2794 called from 
Embedding( W, i ) at /home/gap/inst/gap-4.9.1/pkg/fr-2.4.5/gap/group.gi:2800 called from
func( C[1] ) at /home/gap/inst/gap-4.9.1/lib/coll.gi:1283 called from
CallFuncList( CAP_INTERNAL_PRODUCT_SAVE, arg ) at /home/gap/inst/gap-4.9.1/pkg/CAP-2017.09.25/gap/ProductCategory.gi:526 called from
Product( set, function ( i )
      return (d[1][i] ^ pi) ^ Embedding( W, i );
  end ) at /home/gap/inst/gap-4.9.1/pkg/fr-2.4.5/gap/group.gi:2800 called from
BranchStructure( G ) at /home/gap/inst/gap-4.9.1/pkg/fr-2.4.5/gap/cp.gi:736 called from
...  at *stdin*:26
you can 'return;' after assigning a value
brk> 

I haven't yet figured out which package causes this. Note that a similar error appears in gap-packages/loops#2

[olexandr-konovalov]

Tests now pass, see e.g. https://travis-ci.org/gap-system/gap-docker-pkg-tests-stable-4.9/jobs/400694794 from yesterday. As the discussion in gap-packages/loops#2 explains, that was resolved by the new release of RCWA package.