'SetFeatureObj' is obsolete, use 'SetFilterObj' or 'ResetFilterObj' instead

[olexandr-konovalov]

Now tests fail in the GAP master branch due to multiple warnings of this kind:

########> Diff in /home/gap/inst/gap-master/pkg/guarana-0.96.1/tst/smallexams.\
tst:77
# Input is:
malCol := MalcevCollectorConstruction( exam );
# Expected output:
<<Malcev collector>>
  F : [ 2, 2, 2, 2 ]
  C : <<Malcev object of dimension 4>>
  N : <<Malcev object of dimension 18>>
# But found:
#I  'SetFeatureObj' is obsolete, use 'SetFilterObj' or 'ResetFilterObj' instea\
d
#I  'SetFeatureObj' is obsolete, use 'SetFilterObj' or 'ResetFilterObj' instea\
d
<<Malcev collector>>
  F : [ 2, 2, 2, 2 ]
  C : <<Malcev object of dimension 4>>
  N : <<Malcev object of dimension 18>>
########

[olexandr-konovalov]

See e.g. https://travis-ci.org/gap-system/gap-docker-pkg-tests-master/jobs/453439785.

Guarana tests now moved to the "staging" builds, see e.g. https://github.com/gap-system/gap-docker-pkg-tests-master-staging/commit/eff4aa681bcbfa57d02d6c6f8bee4904eb6f6787 - we need to resolve this and make a new release to fix this.

[olexandr-konovalov]

The fix in 810adef was only partial - there are still problems:

testing: /home/gap/inst/gap-master/pkg/guarana-0.96.2/tst/guarana1.tst
########> Diff in /home/gap/inst/gap-master/pkg/guarana-0.96.2/tst/guarana1.ts\
t:8
# Input is:
N := NilpotentQuotient( F, c );
# Expected output:
Pcp-group with orders [ 0, 0, 0, 0, 0 ]
# But found:
#I  'SetFeatureObj' is obsolete, use 'SetFilterObj' or 'ResetFilterObj' instea\
d
Pcp-group with orders [ 0, 0, 0, 0, 0 ]
########
      80 ms (72 ms GC) and 1.35MB allocated for guarana1.tst
testing: /home/gap/inst/gap-master/pkg/guarana-0.96.2/tst/guarana2.tst
     120 ms (60 ms GC) and 8.66MB allocated for guarana2.tst
testing: /home/gap/inst/gap-master/pkg/guarana-0.96.2/tst/smallexams.tst
########> Diff in /home/gap/inst/gap-master/pkg/guarana-0.96.2/tst/smallexams.\
tst:94
# Input is:
exam := GUARANA.SomePolyMalcevExams( 6 );;
# Expected output:
# But found:
#I  'SetFeatureObj' is obsolete, use 'SetFilterObj' or 'ResetFilterObj' instea\
d
########
########> Diff in /home/gap/inst/gap-master/pkg/guarana-0.96.2/tst/smallexams.\
tst:112
# Input is:
exam := GUARANA.SomePolyMalcevExams( 7 );;
# Expected output:
# But found:
#I  'SetFeatureObj' is obsolete, use 'SetFilterObj' or 'ResetFilterObj' instea\
d
########
########> Diff in /home/gap/inst/gap-master/pkg/guarana-0.96.2/tst/smallexams.\
tst:130
# Input is:
exam := GUARANA.SomePolyMalcevExams( 8 );;
# Expected output:
# But found:
#I  'SetFeatureObj' is obsolete, use 'SetFilterObj' or 'ResetFilterObj' instea\
d
########
   13996 ms (1304 ms GC) and 2.49GB allocated for smallexams.tst
-----------------------------------
total     14196 ms (1436 ms GC) and 2.50GB allocated
              4 failures in 2 of 3 files
#I  Errors detected while testing

(or they are caused by the same issue but in another package?)

[fingolfin]

That's strange, given that the string SetFeatureObj does not appear in guarana 0.96.2 at all. I also cannot reproduce what you report -- what kind of flags or info levels or whatever do you set to trigger it?

[olexandr-konovalov]

Guarana 0.96.2 works with GAP master now, see e.g. https://travis-ci.org/gap-infra/gap-docker-pkg-tests-master/jobs/508717341. Closing this.