-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug in the table of marks with name "2.(A4xA4).2.2" #27
Comments
@gpfeiffer @LiamNaughton I used the following stupid program to figure out which entry is wrong:
which prints
So the representative for class 43 is wrong. The following patch fixes it (I'll submit it as a PR, too): diff --git a/data/tmunitam.tom b/data/tmunitam.tom
index af2bef6..5a6f944 100644
--- a/data/tmunitam.tom
+++ b/data/tmunitam.tom
@@ -1715,7 +1715,7 @@ LIBTOM( "2.(A4xA4).2.2",
1]],[[1,-1,2,-1,1,1,2,1]]],[[[2,-1,1,1,2,-1,1,-1]]],[[[3,-1,1,-1,2,-1]]],[[[3,
1],[4,1,1,1,4,-1,1,1]]],[[[1,1,2,1],[2,1,4,2]],[[1,-1,2,-1,1,1,2,1]]],[[[2,
1],[3,1],[4,1,5,3,4,1,5,-1,4,1,5,-1]],[[2,1,1,-1,2,1,1,1,2,1,1,-1]]],[[[1,1,3,
-1],[4,2,2,1]]],[[[2,1,1,1]]],[[[3,1],[1,1,4,1,1,-1,4,-2]],[[1,-2,3,1]]],[[[2,
+-1,2,1]]],[[[2,1,1,1]]],[[[3,1],[1,1,4,1,1,-1,4,-2]],[[1,-2,3,1]]],[[[2,
1],[3,1],[4,1,5,-1,4,-1,5,1,4,-1,5,-1]],[[1,1,2,1,1,1,2,1,1,-1,2,1]]],[[[3,
1],[4,1,2,1],[5,2,4,-1]],[[1,-1,2,-1,1,1,2,1]]],[[[1,1,3,1],[4,1,2,-1,4,1,2,
1]]],[[[3,1],[4,1,1,1,4,2,1,-1]],[[2,1,1,-1,2,-1,1,-2]]],[[[1,1,2,-1]]],[[[2, Note that I did the naive thing for finding this:
Then I choose a short word that minimized the diff in the fix. In particular, I did not take heed of any other properties of the representative: as far as I could determined, In any case, a new release with this fixed should be made, no? Also, perhaps an improved version of my test program above should be run on all the TOM data, to verify no similar bugs exist? |
RepresentativeTom
does not return the correct representatives, as two of them are conjugate:See my comment in gap-system/gap#3595,
apparently the stored representatives of the table of marks in question are not correct.
The text was updated successfully, but these errors were encountered: